search

free-audio / clap

Audio Plugin API
https://cleveraudio.org/
MIT License
1.77k stars 100 forks source link

Corrected reference to clap_plugin_audio_ports members. #162

Closed spongeboburu closed 2 years ago

spongeboburu commented 2 years ago

The correct names are now referenced in the documentation.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

abique commented 2 years ago

Hi, I've made your change target the next branch instead. Please can you adjust the diff? Cheers,

spongeboburu commented 2 years ago

Ah, sorry, I didn't realize the workflow. Of course!

spongeboburu commented 2 years ago

Sorry for the confusion, while I did use github for many years in my work we use gitlab so I haven't been on github for a few years. I think I have checked all the boxes now, thanks for being patient!

abique commented 2 years ago

@spongeboburu you have dropped one line that you shouldn't.

spongeboburu commented 2 years ago

@abique Once again thanks for your patience. The pull request summary says +2/-3, but when I look at the commit it says +2/-2, I couldn't figure out where that missing line went. Then I realized that the line maybe wasn't accidentally removed by me, but it never existed in main (that I forked from).

Should I perhaps throw this PR away and do it correctly from next instead? I mean, it is such a tiny change so a redo isn't much extra work.

EDIT: looking at my fork it does not contain the next branch at all so I might have done something wrong when forking it. I think the mistake was I didn't understand how the fork feature in the github UI works.

abique commented 2 years ago

Hello,

Thank you for the PR, I've merged it and then restored the lost line. :-)