1.1.7

[abique]

One open question was if preset-discovery.h should be in ext/ or not.

[robbert-vdh]

One open question was if preset-discovery.h should be in ext/ or not.

It's not a plugin extension, but maybe there's another good way to organize this and other factories like the invalidation factory, converters, and whatever else is needed in the future? With the current setup a single subdirectory for all factories would suffice. Then you could even have a draft directory in there to separate draft factories from non-draft factories.

[baconpaul]

One open question was if preset-discovery.h should be in ext/ or not.

It's not a plugin extension, but maybe there's another good way to organize this and other factories like the invalidation factory, converters, and whatever else is needed in the future? With the current setup a single subdirectory for all factories would suffice. Then you could even have a draft directory in there to separate draft factories from non-draft factories.

right so i like the idea of directories for things. ext/ for extensions factory/ for factories. And since this is a factory perhaps it belongs there?

I think just from an "i approach the software anew" perspective it is too prominent in the top directory side by side with clap.h.

otherwise looks correct to me!

[Trinitou]

One open question was if preset-discovery.h should be in ext/ or not.

It's not a plugin extension, but maybe there's another good way to organize this and other factories like the invalidation factory, converters, and whatever else is needed in the future? With the current setup a single subdirectory for all factories would suffice. Then you could even have a draft directory in there to separate draft factories from non-draft factories.

right so i like the idea of directories for things. ext/ for extensions factory/ for factories. And since this is a factory perhaps it belongs there?

Maybe like this?

• factory/(draft/)
  • plugin-instantiation (instead of plugin-factory)
  • plugin-invalidation
  • preset-discovery

[abique]

maybe we need to make those plural?

• factories/
• exts/

I think we can change that as we have clap.h which covers us.

[robbert-vdh]

I'd stick with singular. Using singular for namespaces and directories seems fairly common in most languages, with C# being the only language that comes to mind where the plural form is preferred. But ultimately it's just an aesthetic choice, so it doesn't really matter that much.

[robbert-vdh]

This comment probably also needs to be updated: https://github.com/free-audio/clap/blob/18c4c37f195705e4246d0bf2128abce87e6099a3/include/clap/entry.h#L56

A nice thing about moving the plugin factory to a factory directory is that it's puts more emphasis on the fact that entry.get_factory() can be used for more than just the plugin factory. Since some people were unconditionally returning their plugin factory from that function.

[baconpaul]

I think that is smart but moving the base factory mag be a 1.2 thing perhaps? Also agree with Robbert that singular is fine and often used

[abique]

I think that is smart but moving the base factory mag be a 1.2 thing perhaps? Also agree with Robbert that singular is fine and often used

I think it is fine, it doesn't break the ABI, and I suspect that all of the projects simply includes clap.h.

[baconpaul]

I think that is smart but moving the base factory mag be a 1.2 thing perhaps? Also agree with Robbert that singular is fine and often used

I think it is fine, it doesn't break the ABI, and I suspect that all of the projects simply includes clap.h.

Cool! I agree that as long as we mark the renames in the changelog should be fine

[abique]

I'm happy with clap_preset_discovery_factory_t as a name.

[abique]

There are multiple inconsistencies in the naming of the draft identifiers over the project, but we should not fix them now because it'd create a break-point.

I don't think it is a very important thing, and at the end of the day if the extension becomes stable then the draft disappears.

[abique]

I wondering if with preset discovery, the flags should be set for the preset "as well or instead" of the location?

It could be that within the same folder some preset can be used and some others can't because they rely upon license requirement for some modules etc... So it definitely seems that this is needed for the preset as well.

[Trinitou]

Maybe the factories concept could be documented in the readme as well. Following aspects might be interesting for developpers looking into CLAP for the first time:

• list of fundamental factories / extra / third party factories (analog to the extension lists)
  • plugin_factory is the one necessary for creating plugin instances
  • (one .clap file can "contain" multiple plugins)
  • ARA API CLAP factory & extension (under third-party factories/extensions)
• extensions apply per plugin instance whereas factories are "global"/singleton/per .clap file

I'm not 100% sure about the exact formulations.

Also it could be good to not make it a new "Factories" section in the Readme.md but integrate the points about factories into the "Extensions" section

• maybe then rename the "Extensions" section to "Factories & Extensions"
• As there aren't so many factories, maybe it would be OK to list them together with extensions but tag them as (Factory)
• e.g. under "Fundamental extensions" add a bullet point - Plugin factory (Factory): lets the host create plugin instances

[abique]

We could bring back some info about unknown/unavailable timestamps using the new CLAP_TIMESTAMP_UNKNOWN constant

Thanks! :)