free-audio / clap

Audio Plugin API
https://cleveraudio.org/
MIT License
1.73k stars 98 forks source link

GUI interface clarification #278

Closed sadko4u closed 1 year ago

sadko4u commented 1 year ago

In the struct clap_plugin_gui we see the following interface function:

   // Set the absolute GUI scaling factor, and override any OS info.
   // Should not be used if the windowing api relies upon logical pixels.
   //
   // If the plugin prefers to work out the scaling factor itself by querying the OS directly,
   // then ignore the call.
   //
   // Returns true if the scaling could be applied
   // Returns false if the call was ignored, or the scaling could not be applied.
   // [main-thread]
   bool(CLAP_ABI *set_scale)(const clap_plugin_t *plugin, double scale);

The main problem is, that there is no unit specification for the scale variable in the comment. I assumed that it should be a multiplier which value 1.0 means that UI should be of the original, non-scaled size. But the REAPER DAW reported 100 which, probably, means 100%. This should be clarified in the comment, what units are used.

baconpaul commented 1 year ago

Oooh good catch. I honestly don’t know which one was intended.

abique commented 1 year ago

1 for 100%.