free-audio / clap

Audio Plugin API
https://cleveraudio.org/
MIT License
1.78k stars 100 forks source link

CLAP 1.2.1 #405

Closed abique closed 5 months ago

baconpaul commented 5 months ago

The content is fine with me, but can we clean up the git transactions a bit? Like, rebase/merge all those undo changes into a single commit in the log?

abique commented 5 months ago

The content is fine with me, but can we clean up the git transactions a bit? Like, rebase/merge all those undo changes into a single commit in the log?

We'd loose the history if we squash, also the next branch is on the repo and we can't force push, so I'm not sure if it'll help.

I value the history because we keep a record of the thinking process and the various steps the extension went through. It may be useful one day for someone trying to understand why we've made an extension in a certain way.

It is still possible to read a squashed change set by making a diff between tags.

baconpaul commented 5 months ago

We don’t have to squash. We can partially rebase next to squash some of the interim commits with rebase -I and the do pick and fixup

baconpaul commented 5 months ago

Alex: I added info on rebasing on discord if that helps!