search

free-audio / clap

Audio Plugin API
https://cleveraudio.org/
MIT License
1.77k stars 100 forks source link

clap_plugin_event_filter vs. clap_process.transport #56

Closed Bremmers closed 2 years ago

Bremmers commented 2 years ago

Does clap_plugin_event_filter.accepts(... CLAP_EVENT_TRANSPORT) apply to clap_process.transport?

If yes: This should be documented

If no: Perhaps it should. Calculating tempo and timesig isn't a trivial operation, so you might want to avoid doing that for plugins that don't need it anyway. Perhaps not as big an issue as it used to be with today's computers, but it does add up, especially when audio buffer size is small.

abique commented 2 years ago

Good point! Yes if CLAP_EVENT_TRANSPORT is filtered, then clap_process.transport may be null.

abique commented 2 years ago

Fixed in https://github.com/free-audio/clap/commit/fe29583ae1b4c22c669123da9935ff452d878347 I've forgot the # in the commit message.