search

free-audio / clap

Audio Plugin API
https://cleveraudio.org/
MIT License
1.77k stars 100 forks source link

Allow CLAP_EXPORT to have a custom definition #75

Closed jpcima closed 2 years ago

jpcima commented 2 years ago

If building a plugin which is statically wrapped into another format, the symbol clap_entry is not desired to be visible.

This patch allows to prevent it by passing -DCLAP_EXPORT=.

abique commented 2 years ago

Thank you again! Sorry we're not setup yet regarding CLA. We sort this out and I'll merge your patch. Regards, Alex

robbert-vdh commented 2 years ago

Since CLAP is MIT licensed you wouldn't need a CLA, right? Or are there any plans to relicense it? I'd say having mixed copyright would actually cement its status as an open API, since it wouldn't be possible for the owner to some day decide to relicense everything under an incompatible license without getting approval from the contributors.

abique commented 2 years ago

I want to guarantee that all contributions are made as MIT. Maybe something like that: https://elinux.org/Developer_Certificate_Of_Origin We are looking into it.

jpcima commented 2 years ago

@abique Since it's a trivial modification, can you possibly author it yourself? I am not interested in the authorship.

abique commented 2 years ago

At least your comment settles it :) Thank you for the PR!