free-beer / black-sword-hack

A FoundryVTT extension that implements The Black Sword Hack RPG.
2 stars 4 forks source link

Add es.json #10

Closed WallaceMcGregor closed 1 year ago

WallaceMcGregor commented 1 year ago

Add es.json for Spanish translation.

free-beer commented 1 year ago

I commend you for your contribution. Just a number of points I'd like to raise. First, I think there localizable strings in the constants.js file. It is suboptimal to have these values in the code but this is fallout from the recent change to accommodate more flexible backgrounds. Second, I'm reluctant to accept translations as it's impossible for me to maintain them going forward.

WallaceMcGregor commented 1 year ago

I'm not a programmer but, if you agree, I could try to translate the Description and Name attributes of the constants.js (I think if translated it would still work fine, right?). In any case, even if you don't want to keep the translations because of the extra work, as it is now I think it translates most of the sheet and may be enough for translation to other languages.

free-beer commented 1 year ago

Okay, I can check over what you do. I can put this in but, like I said, I will have no way to maintain it going forward.

WallaceMcGregor commented 1 year ago

Okay, no problem. I think adding the es.json would be enough and that doesn't require any further maintenance.

free-beer commented 1 year ago

Okay, I've made a configuration tweak that I think is also needed. I haven't conducted any testing so there may be some layout issues but I'll commit this anyway.

WallaceMcGregor commented 1 year ago

I just realized that origins are not shown, so you can't add backstories and random character creation doesn't work either.

chrome_3xZXDyhIUr

free-beer commented 1 year ago

Not seeing this in my local installation. Are there any errors in the JS console?

WallaceMcGregor commented 1 year ago

Foundry does not detect any updates so I have manually updated the system.json file and downloaded the es.json. I don't know if that affects it.

chrome_zGd91wTSw5

free-beer commented 1 year ago

Yeah, I have not had time to do a release yet. Can you try creating a completely new character to see if that makes any difference.

WallaceMcGregor commented 1 year ago

image

free-beer commented 1 year ago

If you revert your system (uninstalled and reinstall if necessary) does that address it?

WallaceMcGregor commented 1 year ago

No, it doesn't work in English either.

chrome_QMlFiCbF2e

WallaceMcGregor commented 1 year ago

I have tried a new world and it works. The origins and backgrounds are not translated in the basics tab or in the main tab, but the rest is translated.

chrome_zsDi3HGKzo

chrome_nrfUi3oQBz

free-beer commented 1 year ago

Yeah, I think your character data was messed up somehow. The errors in the console indicated that your backgrounds were blank. Not sure why the origin list was empty though. I could not reproduce this on my end.

free-beer commented 1 year ago

I will also point of the 'warning' I provided in the release notes for the version that introduced the custom background capability as it may be related.

WallaceMcGregor commented 1 year ago

Ok. Thank you and sorry for wasting your time.

free-beer commented 1 year ago

No worries, I'd certainly want to know if there was a problem so, if this occurs again, maybe drop me a line.