free-beer / black-sword-hack

A FoundryVTT extension that implements The Black Sword Hack RPG.
2 stars 4 forks source link

Fairy Tales #20

Closed IgorAthen closed 1 week ago

IgorAthen commented 2 weeks ago

Hello!

I apologize in advance for my English. Please tell me, do I understand correctly that there is no section for fairy gifts? They appear when using the Changeling backstory.

I would also like to offer my help as a translator into Russian. If this is relevant - provide me with a file with all the words and phrases that need to be translated and I will translate them for you.

Thank you!

free-beer commented 2 weeks ago

Hi,

It's true that I have not implemented fairy gifts in the system. To be totally honest, I've not got the time to give this system any attention lately and have just been keep things running with new versions. It's unlikely to change any time soon, so there's not much chance of me implementing gifts unfortunately. With regards to translations, if you look at the root of the repository you'll see there is a languages folder. To translate it you need to provide a Russian version of the en.json that's found in this folder. I will note that, if I ever do start adding functionality to the system again, I will only ever be able to add English text, so the level of translation will deteriorate unless someone comes back and regularly updates these files - just letting you know what 'volunteering' to do translations means.

Regards, Peter

IgorAthen commented 2 weeks ago

Can you please tell me what I should have said to finally finish the character sheet for this system? I would be happy to donate to you, but paypal doesn't work in my country.

I would also be grateful if you could explain how to select the suggested birthplace in the sheet? Or does it only work with random generation?

Could we contact in any messenger to discuss the details of the translation and other things?

p.s. I also noticed that the characteristics do not automatically change when the origin changes.

free-beer commented 2 weeks ago

Not making any promises about implementing any functionality, apologies. With regards to the birthplace, I left this as a free form text field as it means that you can invent your own birth places. You can freely type in one of the ones from the rules and the random generator uses that list.

With regards to the translation, here's what's needed...

IgorAthen commented 1 week ago

Hello again! Translation is already in progress, thanks for the instructions! Also noticed that the characteristics do not automatically change when the origin changes.

IgorAthen commented 1 week ago

ru.json

free-beer commented 1 week ago

Okay, the Russian translations file has been incorporated. I had to add some styling because some of the translations run long for the space available and I've only done minimal checking that it's showing properly. The new version is v1.2.6.

IgorAthen commented 1 week ago

изображение изображение

Hi! I'll make some adjustments to the translation to make it more original, okay? Unfortunately, I just now found some bad solutions. Please tell me why the backgrounds and origins were not translated? I also wanted to translate the background descriptions, they were not in the translation file, how can I do this? Thanks for the prompt answers!

free-beer commented 1 week ago

The answer is, unfortunately, because the text for these is actually in the code. To fix this I would need to incorporate a translation capability for them. I might get the time to do this, I might not - like I said I'm not committing to making any substantial, non-fix code changes.

IgorAthen commented 1 week ago

ru.json Got it, thank you very much. If you provide me with information on how I could optimize this as much as possible so that the process does not take up extra time for you, I will gladly do so, as I would not like to abandon what I started halfway through. I am also attaching a file with translation corrections.

IgorAthen commented 1 week ago

изображение Hi! I also noticed that when choosing Gifts, they are not transferred to the main character sheet.

free-beer commented 4 days ago

NOTE: This is the last comment on this issue, please don't post anymore here as it is closed.

The gift thing is working as expected. Selecting a gift is simply intended to reflect your choice upon reaching the level. The gift itself needs to be added to the character separately. There are a bunch of issues about automating that, so I've bypassed them by simply not automating it at all. I won't be changing this.

The background descriptions are, from version 1.2.7, now translatable. These descriptions contain HTML markup tags and, if you're planning on translating them, then you will have to work around these.