search

free-pdk / pdk-includes

Device Include files for Padauk MCUs
GNU General Public License v2.0
10 stars 8 forks source link

HAS_* macro names #2

Closed spth closed 4 years ago

spth commented 4 years ago

I think the HAS_* macro names have a high risk of conflicting with user names (one can easily imagine a programmer choosing HAS_COMP or HAS_ADC for a macro referring to some feature in their software). Maybe some kind of prefix could help?

serisman commented 4 years ago

Makes sense.

I just added a PDK_ prefix, so HAS_ADC is now PDK_HAS_ADC.

Does that work?

serisman commented 4 years ago

Fixed with: https://github.com/free-pdk/pdk-includes/commit/4a792b61cc48910d3ba1b53779f4a7818ff0eb6a and: https://github.com/free-pdk/pdk-includes/commit/79d0ed85e42d46384bf5a1943d3d7d3f33909242