search

free / prometheus

The Prometheus monitoring system and time series database.
https://prometheus.io/
Apache License 2.0
48 stars 5 forks source link

x-rate patch conflicts on v2.18.0 #12

Closed sylr closed 4 years ago

sylr commented 4 years ago

Hi @free 👋

I'm sorry to bug you again about that but any chance you could see if you could apply your patch on top of prometheus v2.18.0 ?

There seems to have been some major refactoring there so I would understand if you don't want to do it anymore.

Regards.

free commented 4 years ago

Will give it a try when I can find some time. Feel free to ping me again if you don't see any activity.

sylr commented 4 years ago

Brilliant! Thank you 🙏

sylr commented 4 years ago

Hi @free, have you had the time to take a look ?

free commented 4 years ago

Nope, not yet. I have a deadline today (which is what I was busy with a month ago too). Ill try to get to it over the next few days.

free commented 4 years ago

Still haven't forgotten, was just kidding myself regarding how busy I'm going to be. (o:

Still plan to do it particularly now that 2.19.0 is out.

sylr commented 4 years ago

Nice! Thanks @free.

free commented 4 years ago

Here it is, only a couple of months late: https://github.com/free/prometheus/releases/tag/2.19.2-xrate (o:

Tests all pass, but haven't managed to build release binaries yet. Hope to get to that in a couple of days.

sylr commented 4 years ago

Thank you!!

free commented 4 years ago

And here are the binaries, for those who haven't yet built their own: https://github.com/free/prometheus/releases/tag/2.19.2-xrate