free / prometheus

The Prometheus monitoring system and time series database.
https://prometheus.io/
Apache License 2.0
48 stars 5 forks source link

bring x-rate upstream #16

Open roidelapluie opened 2 years ago

roidelapluie commented 2 years ago

Hello,

I'd like to know if you would be interested into bringing x-rate upstream in Prometheus, behind a feature flag? Exact details would be TBD, but we are open to this idea and would welcome a formal proposal to move forward in this direction.

if you want to contribute it, we could re-analyze your proposals with a fresh eye and find the best outcome for the community.

thanks!

free commented 2 years ago

Hey Julien,

Yeah, totally! I'm a bit rusty on Golang (haven't really coded anything in almost 2 years), but the concept and implementation are pretty simple, so I'm happy to give it a go.

Let me know what you need and I will try to oblige.

Cheers!

roidelapluie commented 2 years ago

For now the idea would be to put the approaches described in the upstream issue in a clear google doc instead of a github issue. once it is done, we can start discussing a bit easily.

Note that I want to solve this issue, so the goal is really not to make you lose your time; the goal is to have this actually implemented quite soon.

free commented 2 years ago

Should I go ahead and start that document (when I can find the time) or would you do it? (E.g. if there's some structure / process it must follow rather than a free-form proposal.)

roidelapluie commented 2 years ago

I have shared an empty design doc with you, you should be able to use it and move forward. Thanks

free commented 2 years ago

Finally found the time to go through the whole document. I had to rush through it towards the end (or it might have taken me another month to get back to it) but I believe I've done a mostly decent job.

Will try to address any comments as they come, but it may take some time to do so.

roidelapluie commented 2 years ago

Thanks a lot!

free commented 2 years ago

Did another pass a few days ago, please let me know if you need anything specific on my part.

sylr commented 2 years ago

@roidelapluie ? :)