search

free5gc / smf

Apache License 2.0
19 stars 95 forks source link

Fix UPF nodeID parsing issue when using FQDN #6

Closed abousselmi closed 4 years ago

abousselmi commented 4 years ago

Hello @free5gc-org,

When an FQDN is used as UPF node_id in SMF configuration, IP parsing fails and PFCP session is not established between SMF and UPF. To resolve this issue, and since there is no native way to check whether node_id is IPv4, IPv6 or an FQDN, we need to try a name resolution before parsing the IP.

This issue was experienced in the docker version of free5gc: https://github.com/free5gc/free5gc-compose/issues/9. This also provides a fix to issue https://github.com/free5gc/free5gc/issues/111.

Thanks to @hhoai we now know the root cause of the problem and the solution. The verification step will make sure that the nodeID is updated only when the DNS resolution succeeds.

Cheers,

abousselmi commented 4 years ago

As per the suggestion of @sh-sekigawa, resolving the NodeID as suggested here will make the FQDN case useless which is not the intended behaviour. The NodeIdType will never be a pfcpType.NodeIdTypeFqdn as the resolution happened before assigning the type.