free5gc / upf

Apache License 2.0
32 stars 51 forks source link

globalXactId maintenance error #2

Closed Dorian1982 closed 3 years ago

Dorian1982 commented 4 years ago

In the PfcpXactLocalCreate function, below line: xact->transactionId = (globalXactId == PFCP_MAX_XACT_ID ? PFCP_MIN_XACT_ID : globalXactId + 1);

should be: xact->transactionId = (globalXactId = (globalXactId == PFCP_MAX_XACT_ID ? PFCP_MIN_XACT_ID : globalXactId + 1));

otherwise, globalXactId will NOT +1

free5gc-org commented 3 years ago

This issue was already fixed. Please pull the latest commit (3e10a73c6f64fd7e6378e4248e0703ecc1da9e18).