search

free5lot / hid-apple-patched

Allows to swap the Fn key and left Control key and other tweaks on Macbook Pro and Apple keyboards in GNU/Linux
GNU General Public License v2.0
349 stars 61 forks source link

Add option to use Lock key as Delete key #84

Closed mklewitz closed 1 year ago

mklewitz commented 2 years ago

Apple's Magic Keyboard 2 is available with Touch ID or Lock key. This commit adds an option to use the Lock key as Delete key.

free5lot commented 2 years ago

Thank you @mklewitz for your contribution! Seems to be an useful feature.

Please provide your experience with the keyboard and this feature you send, what is working and what is not for you.

I hope other users of keyboard with a lock key (I have none) will try the feature and provide their experience with this feature. If everything works it can be merged to the repo. Thanks again.

free5lot commented 2 years ago

I reviewed the commit and the code seems to be clean and nice. You even modified install script.

I have no lock key, so I can not test it. So, let's wait for another opinion, maybe you know somebody with such a keyboard and GNU/Linux to try it for themselves?

mklewitz commented 2 years ago

Unfortunately I know no one else using an apple keyboard with linux. I'm using this at work every day and it works great.

free5lot commented 2 years ago

How long have you been using your modification as presented?

mklewitz commented 2 years ago

Since a few days before opening the pull request.

mklewitz commented 1 year ago

Still using it every day. Works like a charm :)

free5lot commented 1 year ago

OK, I consider it tested enough then. I hope other people with this key will be ready to test it soon. Thanks again for PR.

lostfictions commented 1 year ago

Confirming that this works great for me, and resolves the longstanding issue that was keeping me from using the Magic Keyboard that I was given. Thanks a lot for this!

Really hope that this option (as well as the other options this patched module offers beyond swap_fn_leftctrl) land in the kernel at some point!