freeCodeCamp / 100DaysOfCode-twitter-bot

Twitter bot for #100DaysOfCode
https://twitter.com/_100DaysOfCode
BSD 3-Clause "New" or "Revised" License
282 stars 110 forks source link

Consider adding development branch #122

Closed spences10 closed 6 years ago

spences10 commented 6 years ago

Please consider adding a development branch and possibly a branch for adding patches to

Also please consider adding the following protection on branches master, development and patch so they are protected:

image

Thanks

amandeepmittal commented 6 years ago

I do not have access to these settings. @QuincyLarson might be able to help us in this matter?

spences10 commented 6 years ago

Maybe I should also update the contribution guidelines RE, make a branch from development give it a naming convention like user/branch/feature-issueNumber

Is that why there are so many branches on this repo as well[29 branches]?

amandeepmittal commented 6 years ago

Yes, that is the reason.

QuincyLarson commented 6 years ago

@amandeepmittal I've granted you full admin privileges for this project (I hadn't realized you didn't have them).

Feel free to create any branches or configurations you see necessary. Let me know if I can do anything to help :)

amandeepmittal commented 6 years ago

Thanks @QuincyLarson! @spences10 will update the branch as per your instructions over the weekend.

spences10 commented 6 years ago

Cool, just to expand on the patch branch, it's how I have been managing dependency updates, I merge them into there then if there are any failures (failed Travis build) then the dev/master branches are not affected

spences10 commented 6 years ago

I'l like to help maintain this too if that's ok with you @QuincyLarson and @amandeepmittal 🙏

I've contributed quite a lot to this project and would be happy to help maintain it.

amandeepmittal commented 6 years ago

Ofcourse @spences10. You are the biggest contributor to thos project. @QuincyLarson can we give him the rights and add him as a maintainer?

QuincyLarson commented 6 years ago

@spences10 I've granted you admin access as well :)

spences10 commented 6 years ago

Wheeeee! Thanks @QuincyLarson 🙏

spences10 commented 6 years ago

This can be closed now, I have done all the admin

@amandeepmittal do you know any good CI tools for Heroku?

amandeepmittal commented 6 years ago

Travis.