freeCodeCamp / 2016-new-coder-survey

196 stars 61 forks source link

[WIP] Add maps for location, gender, ethnicity and age #54

Closed krisgesling closed 7 years ago

SamAI-Software commented 7 years ago

Website preview is here

krisgesling commented 7 years ago

I've fixed the excessive file loading and the flickering has stopped even thought I haven't put any transitions in, so looks like the DOM is quick enough. Have changed the colors, not quite to your suggestion but see what you think. Tweaked the sizing further and added an additional breakpoint. Let me know if it's still too big on your screen. Changed the tooltip descriptions for age but it doesn't look that great, so I'll keep thinking about different wording. Changed the 'All' map to be called 'Location' and changed the descriptive text to make it clearer for the user. Does that help with the weird logic?

SamAI-Software commented 7 years ago

<- back to checklist

@krisgesling looks great and I like tabs colors! And yes, it fits my screen now. Also after my PR the navbar will be even smaller, so all good :+1:

Changed the 'All' map to be called 'Location' and changed the descriptive text to make it clearer for the user. Does that help with the weird logic?

Yes, it's better, but as I said, user research will be the best decision. We can just ask campers about it, when it's done.

Also we can change the "water" color to transparent, and put the color legend inside the map.

Map 1

map1

Map 2

map2

Map 3

map3

Map 4

map4

I like map 1 & 3, but others also good.

SamAI-Software commented 7 years ago

<- back to checklist

Btw, we need to work a bit more on mobile version. Don't worry abt nav, it's already fixed in my PR.

image

If we set "water" color to transparent, the problem with Location tab should be fixed by itself.

And you can probably make map wider. Definitely left side 10px, may be right, too.

image

krisgesling commented 7 years ago

Changes made:

In regard to scroll zoom this is currently what allows mobile users to pinch zoom. Also on mobile devices while scrolling down the page a similar thing happens when you try swiping on the map you move the map instead of scrolling the page. So I can replace them with arrows and +/- buttons but it will be very slow navigating the map particularly on a mobile device.

SamAI-Software commented 7 years ago

<- back to checklist

Great! Looks awesome on all my screens! :+1:

A few small issues:

Groups

Change percentage groups according to new "leaders"

image

Probably for ethnicity map we can separate Canada(27%), USA (31%) and Nepal (30%) from South Africa (63%), Thailand (52%), Malaysia (58%), South Korea (54%), etc.

E.g. 0-10%, 11-15%, 16-20%, 21%-35%, 36+%


Colors

Also colors are very similar at ethnicity and gender maps, which makes it hard to read. (Especially last 2 colors)

image

image

Good example is Age map, because it goes from very light color to very dark one, so it's very easy to spot the differences between countries, and that's exactly the reason to make a country breakdown.

image

SamAI-Software commented 7 years ago

<- back to checklist

Better make it right side & smaller & italic & opacity same like at the bar charts v2.1

image

image