Closed JoyShaheb closed 11 months ago
@JoyShaheb
Can you remove your changes for the dice game from this PR since you already have another open PR for the dice game?
@JoyShaheb
Can you remove your changes for the dice game from this PR since you already have another open PR for the dice game?
done @jdwilkin4
@JoyShaheb I still see changes to files in the Dice Game project on this PR.
@JoyShaheb, unfortunately it looks like there are still some changes to the dice game files.
At this point it might be best to pull in the latest dice game files from upstream/main
with this command: git checkout upstream/main -- javascript-algorithms-and-data-structures/learn-intermediate-algorithmic-thinking-by-building-a-dice-game/*
Then to commit those changes with a message saying that you're reverting them to what's currently in upstream/main
.
@JoyShaheb I still see changes to files in the Dice Game project on this PR.
Done this time
Hey @JoyShaheb, thanks for your patience.
I just noticed a few more minor things that I'll leave as review comments.
Hey @JoyShaheb !
Since this project is currently being broken down into steps here my suggestion for this curriculum expansion PR would be to wait to make anymore changes until the forum leaderboard project has been approved and merged into the main repo.
That way we don't have to worry about trying to keep up with two different versions of the project and we can just copy the final seed code from that PR
@scissorsneedfoodtoo Would you mind moving your comments over to this open PR? 🙏
Thanks! 😄
Checklist:
Update index.md
)