search

freeCodeCamp / CurriculumExpansion

Creative Commons Attribution Share Alike 4.0 International
313 stars 105 forks source link

Learn Encapsulation by Drawing a Projectile Trajectory #370

Closed ilenia-magoni closed 3 months ago

ilenia-magoni commented 7 months ago

I am creating a PR so I can share the prototype

how to test: execute the py file in the terminal, it will have an interactive menu

zairahira commented 7 months ago

I went through the project and it looks good. I have some suggestions, they are not compulsory to implement though.

  1. The error handling can be improved. For example:

    • The angle -45 freezes the output.
    • Entering any number other that 1-4 also freezes the output.

  2. In the graph, points close in value seem to appear in a single line, making the trajectory look flat. Is there a way to improve this?

ilenia-magoni commented 7 months ago

2. In the graph, points close in value seem to appear in a single line, making the trajectory look flat. Is there a way to improve this?

no, it is using the max precision possible to create the points, as it's rounding to the nearest character. It would need an actual graphic interface where it's possible to use pixels