freeCodeCamp / CurriculumExpansion

Creative Commons Attribution Share Alike 4.0 International
315 stars 105 forks source link

chore: adding student table workshop #389

Closed jdwilkin4 closed 4 months ago

jdwilkin4 commented 4 months ago

Checklist:

Closes #388

jdwilkin4 commented 4 months ago

I like how the styles look but I am on the fence about using inline styles because we will need to be super careful about messaging. So we will probably need to add a note in the steps for adding inline styles that while inline styles are an option, usually it is better to use an external stylesheets for seperation of concerns reasons.

moT01 commented 4 months ago

We definitely don't have to add them - but I think these are different from inline styles, they are actual table element attributes. So I think they could be beneficial in this workshop.

jdwilkin4 commented 4 months ago

It looks like these attributes are deprecated according to MDN https://developer.mozilla.org/en-US/docs/Web/API/HTMLTableElement/border https://developer.mozilla.org/en-US/docs/Web/API/HTMLTableElement/cellPadding https://developer.mozilla.org/en-US/docs/Web/API/HTMLTableElement/cellSpacing

jdwilkin4 commented 4 months ago

we could add a style element and add some internal styles for the heading styles

moT01 commented 4 months ago

these attributes are deprecated

Nice catch. Yea, if they're deprecated, we probably shouldn't use them.

we could add a style element

So, style code that wouldn't be visible to the user? I'm not sure I really like that cause it could be confusing. If they go create a table elsewhere, they won't know why it doesn't look good.

I also see on mdn that "If the scope attribute is not specified, ..., then browsers automatically select the set of cells to which the header cell applies."

So it sounds like we don't necessarily need that either. Maybe we just go with this as-is.