freeCodeCamp / CurriculumExpansion

Creative Commons Attribution Share Alike 4.0 International
313 stars 105 forks source link

feat: add lunch picker lab (JS only) #492

Closed zairahira closed 1 month ago

zairahira commented 2 months ago

Checklist:

Closes #428

zairahira commented 2 months ago

According to the sheet, the array methods like removing and adding elements come after this lab. However, at this point campers would know how to access and update items. Should I make changes according to that?

Dario-DC commented 2 months ago

There's a mismatch between the issue related to this PR and the sheet apparently. Unless the array methods are going to be introduced in the previous workshop (which I think has not been created yet) and then mentioned in the following videos.

Is that possible? @zairahira @jdwilkin4

jdwilkin4 commented 2 months ago

I went ahead and updated it on the sheet. So push, pop, shift and unshift will be taught before this in the lecture block

jdwilkin4 commented 2 months ago

I just added the workshop PR that will go before this lab

https://github.com/freeCodeCamp/CurriculumExpansion/pull/495

zairahira commented 2 months ago

@Dario-DC I have added a few more methods like push() and pop(). Let me know what you think of this one.

moT01 commented 1 month ago

Just throwing out ideas - you could start with an empty array, or maybe just one item in it, and have them push several more instead of just one.

"You should create a adultsMenu array with one item, "Salad", in it. "You should use "push" to add three more food items to the adultsMenu array" "You should create a kidsMenu array with one item, "Pizza", in it. "You should use "push" to add two more food items to the kidsMenu array"

I think this works as-is, but I think that might make it a little better.

If you just want to update the user stories, I'll take another look @zairahira - or you can add something like my suggestion and update them if you want.

zairahira commented 1 month ago

@moT01 I have added a few more stories as suggested. Let me know what you think.