freeCodeCamp / CurriculumExpansion

Creative Commons Attribution Share Alike 4.0 International
313 stars 105 forks source link

feat:add semantic html lab #496

Closed larymak closed 1 month ago

larymak commented 2 months ago

Checklist:

Closes #385

screenshot-127 0 0 1_5500-2024 07 28-10_29_39

jdwilkin4 commented 1 month ago

Hey @larymak !

It looks like you still have the CSS grid project in here. Can you update your PR to remove that please?

An then once the merge conflicts are resolved, then we should be good to go.

moT01 commented 1 month ago

I see a lot of leftovers of an attempted merge conflict fix. You should remove those @larymak. Let me know if you need any help.

larymak commented 1 month ago

I see a lot of leftovers of an attempted merge conflict fix. You should remove those @larymak. Let me know if you need any help.

@moT01 yeah I would appreciate some help with this kindly

moT01 commented 1 month ago

I see two folders, a css-grid folder, and an event-page folder. We can just delete the css-grid folder correct? The stuff we want is in the event-page folder?

larymak commented 1 month ago

I see two folders, a css-grid folder, and an event-page folder. We can just delete the css-grid folder correct? The stuff we want is in the event-page folder?

Yeah, that's correct

moT01 commented 1 month ago

Do you want to try deleting it? Let me know if you need help.

larymak commented 1 month ago

Do you want to try deleting it? Let me know if you need help.

Done, The CSS folder has been deleted.

Dario-DC commented 1 month ago

I see that the grid project has been deleted, so merging this PR would remove it from the main branch. This PR should not touch the files in the /css-grid folder at all. Is that right? @moT01 @larymak