feat: add lightbox lab - Githubissues

freeCodeCamp / CurriculumExpansion

Creative Commons Attribution Share Alike 4.0 International

315 stars 105 forks source link

feat: add lightbox lab #523

Closed zairahira closed 2 months ago

zairahira commented 3 months ago

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)

Closes #455

To-do:

[ ] Move images to cdn

zairahira commented 2 months ago

@moT01, I have updated the user stories based on your suggestions. However, I would still ask the campers to use the provided images. Otherwise, it would be difficult to test which image is the thumbnail and which one is the full size.

@jdwilkin4, Would we at any point provide the html in the boiler plate? If so, we can simplify user stories further.

jdwilkin4 commented 2 months ago

Looking at the other labs in this module, it looks like the HTML is not provided to campers. For consistency, we should have them add the relevant HTML.

So we can keep the updated user stories