refactor: object lab (JS only)

freeCodeCamp / CurriculumExpansion

Creative Commons Attribution Share Alike 4.0 International

313 stars 105 forks source link

refactor: object lab (JS only) #565

Closed Dario-DC closed 3 weeks ago

Dario-DC commented 4 weeks ago

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)

Related to #429

Since the block dedicated to functions has been moved before this one, I've modified the lab to use a function.

Dario-DC commented 3 weeks ago

I have refactored the code as suggested @jdwilkin4 Personally, I would not include the several function calls and console.logs in the user stories. What do you think?

Dario-DC commented 3 weeks ago

Just saw that you put the waiting update label on this. What should be updated? @jdwilkin4

jdwilkin4 commented 3 weeks ago

Based on your comment here, it seemed like you wanted to make some updates. https://github.com/freeCodeCamp/CurriculumExpansion/pull/565#discussion_r1747474710

if you don't want to make any more changes, though then this can go in 👍

Dario-DC commented 3 weeks ago

Sorry about the confusion. I did not include the last part of the code (console.logs and other function calls) in the user stories and I was asking if that was fine. I would have been updating the code in case we wanted to check that part too.