feat: add regex lab - Githubissues

freeCodeCamp / CurriculumExpansion

Creative Commons Attribution Share Alike 4.0 International

315 stars 105 forks source link

feat: add regex lab #613

Closed Dario-DC closed 1 month ago

Dario-DC commented 1 month ago

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)

Closes #458

Dario-DC commented 1 month ago

@zairahira my idea was to have the HTML rendered on the page (see the last user story). I guess we can change the code if we don't want that.

zairahira commented 1 month ago

I'd suggest it is better to show the raw HTML because visually, there seems to be no difference in rendering either markdown or HTML.

jdwilkin4 commented 1 month ago

Ultimately, I think it should be up to you if you want to update the functionality to convert markdown to raw HTML like zaira suggested or update the language to better convey a markdown parser

Dario-DC commented 1 month ago

What about something like this?

And with this change I would keep the table.

jdwilkin4 commented 1 month ago

Yeah, that works for me

zairahira commented 1 month ago

This is looking good @Dario-DC.

Dario-DC commented 1 month ago

Prototype updated. Let me know if you think I can go ahead and merge this PR.

Dario-DC commented 1 month ago

looks good, let's get this merged in.

Are you are going to work on this lab for the main repo? Or do I need to update the priority list of items so someone else can pick this up?

I'll start to work on it tomorrow :+1: