freeCodeCamp / Developer_Quiz_Site

This is a quiz site filled with over 1200+ questions on programming.
https://developerquiz.org
BSD 3-Clause "New" or "Revised" License
232 stars 339 forks source link

chore: move to use vite as devtool #929

Closed shootermv closed 6 months ago

shootermv commented 6 months ago

Summary of changes

migrate project to use vite devtool because it more modern tool for react projects

Checklist

closes #928

socket-security[bot] commented 6 months ago

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
vite 5.0.10 network, filesystem, shell, environment +45 264 MB vitebot
vitest 1.1.0 filesystem, shell, environment +86 269 MB oreanno
vite-tsconfig-paths 4.2.2 network, filesystem, shell +48 265 MB aleclarson
@vitejs/plugin-react 4.2.1 network, shell +83 275 MB vitebot
@types/jest 27.5.1...29.5.11 eval +21/-5 2.91 MB types
@types/node 17.0.35...18.0.0 None +0/-0 1.7 MB types
@testing-library/jest-dom 5.16.1...6.1.5 shell +107/-12 271 MB testing-library-bot

🚮 Removed packages: react-scripts@5.0.0

jdwilkin4 commented 6 months ago

Hey @shootermv !

I was able to fork your copy of the project. When I run it locally I get an error for the manifest.json

Screenshot 2023-12-21 at 8 05 56 PM

So I tried my own github pages build of the project and the build failed due to issues with the manifest.json

Screenshot 2023-12-21 at 8 07 03 PM

Also, I was googling around and for the gh-pages package we are using it looks like we need to update the deploy script to point to the dist folder instead of the build folder according to this article https://dev.to/rashidshamloo/deploying-vite-react-app-to-github-pages-35hf

Since this is a migration, we will have to test actual builds of test sites to make sure that this PR doesn't accidentally break the production site. I am testing everything by creating a github pages site on my forked copy of your fork. I would suggest testing the builds on your end and seeing if you can your forked copy to build a github pages site to make sure the migration work.

Hope that helps 👍

jdwilkin4 commented 6 months ago

Here are my settings for testing the builds to GH pages

Screenshot 2023-12-21 at 8 15 35 PM
shootermv commented 6 months ago

Sorry, totally my bad! i will look to fix it asap

shootermv commented 6 months ago

After looking at the tutorials you sent - i changed deployment script and was able to deploy to my gh-pages Please check if you able to run & deploy the project now without issues... p.s. Thank you for guidance!

shootermv commented 6 months ago

Was able to do a build and preview locally and it was working on my end.

So we should be good to go. I vote we merge this in and see if the build goes through. 👍

Then if there are any issues, we can always roll back a commit to the old version and debug from there and try again 👍

I would suggest holding off on deleting this branch until we know the production build worked out

Totally agree