search

freeCodeCamp / Developer_Quiz_Site

This is a quiz site filled with over 1200+ questions on programming.
https://developerquiz.org
BSD 3-Clause "New" or "Revised" License
246 stars 348 forks source link

[Bug] - deployed site not updating with latest changes #976

Closed jdwilkin4 closed 3 months ago

jdwilkin4 commented 3 months ago

What bug did you find in the codebase?

Some design changes were added but that haven't shown up on the live site. The design changes work fine locally when you pnpm run start It also works locally, when you do a local build and run pnpm run preview

But on the live site, the design changes don't show up. After digging deeper, it looks like the last few PR changes are not reflected in the site.

On the live site, the total number of random questions shows 1560 but locally the total number of questions shows 1570.

It is possible something went from the the previous configuration changes that happened a few months back. So that might be a good place to start looking.

shootermv commented 3 months ago

I cans see pages-build-deployments task no more running (Lastime is 3 days ago)

jdwilkin4 commented 3 months ago

That job was triggered by me a few hours ago.

Screenshot 2024-07-01 at 3 22 53 AM

But I have found the issue.

If you look closely at the link to where it is deploying to, it is incorrect

Screenshot 2024-07-01 at 3 23 25 AM

The last deployment for the actual developerquiz.org was back in April

Screenshot 2024-07-01 at 3 23 44 AM

ever since then, it has been deploying to https://opensource.freecodecamp.org/Developer_Quiz_Site/

So it broke somewhere around that time

jdwilkin4 commented 3 months ago

I am going to remove the help wanted label because the team is looking into setting it back to the correct url

raisedadead commented 3 months ago

This issue (rather confusion) is coming from the conflicting nature of the deployment and settings.

I see that there is action configured for pages deployment, that abstracts deployment to a third-party package. At the same time I see that there is default setting which uses gh-pages branch based deployment.

The former will "upload" files from the dist and the later will use a GitHub native feature (you see it as the pages-build-deployment action (not the same as our deploy workflow).

In simple terms this is a bit convoluted and conflicting approach that can break.

I am working to move this over to Cloudflare Pages. Which is simpler to manage from our end. I will have a PR shortly.

jdwilkin4 commented 3 months ago

Awesome, thanks @raisedadead for looking into this.

I am kind of surprised we haven't run into this issue before, but I am glad we are moving to cloudflare pages.

shootermv commented 3 months ago

I know that vercel cloud has very simple way to integtrate with github, may it is something worth to consider to move to...