freeCodeCamp / LearnToCodeRPG

A visual novel video game where you learn to code and get a dev job 🎯
https://www.freecodecamp.org/news/learn-to-code-rpg-1-5-update/
BSD 3-Clause "New" or "Revised" License
1.06k stars 110 forks source link

misquoting when taking a day off #11

Closed alandgmendes closed 2 years ago

alandgmendes commented 2 years ago

What bug did you encounter?

character thinking about working at the caffe when i had walked around the park

Steps to Reproduce

on day 9 i took a break, went to the park, and when i came back home, i wondered about tech words i heard on barista shift, wich i didn't do it on the day. maybe check if the before-bed thoughts are properly assigned to the activities during that day

Screenshots

image image

Additional Information

No response

AgustinRamiroDiaz commented 2 years ago

@RuolinZheng08 the problem is in game/scripts/labels at line 129

if not has_triggered_ending_today: player smile "Hmmm... Let's see. Do I have any cool tech terms I caught during my barista shift that I need to research?"

Maybe change the phrase to something like

if not has_triggered_ending_today: player smile "Hmmm... Let's see. Do I have any cool tech terms I caught during the day that I need to research?"

Or using the day_activity to generate the phrase

I was about to fix some issues but you are blazing fast! Great work!

RuolinZheng08 commented 2 years ago

Fixed in https://github.com/freeCodeCamp/LearnToCodeRPG/commit/5484a5412fe95923bf5a57e47baa622f4d4cc255. Thanks!