freeCodeCamp / LearnToCodeRPG

A visual novel video game where you learn to code and get a dev job 🎯
https://www.freecodecamp.org/news/learn-to-code-rpg-1-5-update/
BSD 3-Clause "New" or "Revised" License
1.06k stars 110 forks source link

Link format makes it tough to tell what's a link or not #32

Closed srsexton94 closed 2 years ago

srsexton94 commented 2 years ago

What bug did you encounter?

On the August 3 call to the Annika character there's what looks like a link to https://developerquiz.org, but it doesn't seem to link anywhere

In general accessibility-wise I know the advice is to not distinguish interactive elements solely by one characteristic (ie color) and this is all the more important for links in bodies of text (ie some color-blind users won't be able to tell these are meant to be links at all.)

Currently, I believe your links fail WCAG 1.4.1 - I'd recommend adding an underline to links and only applying that styling to things that are actually linking somewhere. Ideally, you might also consider making the color more distinct from your body text and making the cursor a pointer when over links (not sure if that's an accessibility issue but I know it confused me haha)

Steps to Reproduce

Play the game to august 3rd, get on the phone call to Annika, and proceed to the step where she's discussing developer quizzes. Try and click on the link. The game will proceed to the next dialogue slide instead.

Screenshots

No response

Additional Information

No response

jdwilkin4 commented 2 years ago

Hi @srsexton94 !

It is my understanding that the reference to the developer quiz site is not supposed to be an active link in the game. I think it is just there so people can explore the site later on their own outside of the game. But it does make sense to remove the link styling so people aren't tempted to click on it.

RuolinZheng08 commented 2 years ago

Fixed in a45212e