feat: add fieldset and legend in eventForm for screen readers

freeCodeCamp / chapter

A self-hosted event management tool for nonprofits

BSD 3-Clause "New" or "Revised" License

1.92k stars 359 forks source link

feat: add fieldset and legend in eventForm for screen readers #2352

Closed Sboonny closed 1 year ago

Sboonny commented 1 year ago

[x] I have read Chapter's contributing guidelines.
[x] My pull request has a descriptive title (not a vague title like Update README.md).
[x] My pull request targets the main branch of Chapter.

Screen Readers may need additional context of what does checking invite-only does, for now they will know it's the type of the event

ghost commented 1 year ago

👇 Click on the image for a new way to code review

#### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/freeCodeCamp/chapter/2352/253a5783/17c082c431ef33800c93459ede5e042f0534c449.svg)](https://app.codesee.io/r/reviews?pr=2352&src=https%3A%2F%2Fgithub.com%2FfreeCodeCamp%2Fchapter) #### Legend CodeSee Map legend

gikf commented 1 year ago

Event Type sounds a bit weird to me when describing invite-only event. Not that this isn't technically correct.

I don't have idea for what that could be changed. What came to my mind is grouping the Invite only checkbox together with the Capacity and call them both Attendee restrictions or Event restrictions. What do you think?

Sboonny commented 1 year ago

Sorry, I have missed the comment while I was sick, I am happy with adding the changes.

Just to add another option, this change is purely for screen readers, if it isn't visually pleasing, we can add a legend with too many details and set it as visibility hidden.

but I don't know what to add as well 🤣.

Edit: shouldn't have pushed the latest commit.