feat: disable button when formState is not valid - Githubissues

freeCodeCamp / chapter

A self-hosted event management tool for nonprofits

BSD 3-Clause "New" or "Revised" License

1.92k stars 360 forks source link

feat: disable button when formState is not valid #2364

Closed gikf closed 1 year ago

gikf commented 1 year ago

[x] I have read Chapter's contributing guidelines.
[x] My pull request has a descriptive title (not a vague title like Update README.md).
[x] My pull request targets the main branch of Chapter.

Disables submit button when form state is not valid.
mode: 'all' validates fields both on blur and change events. Documentation (https://react-hook-form.com/api/useform) suggests validating on change can significantly affect performance, I didn't look very carefully for that, but haven't noticed trouble with that.

ghost commented 1 year ago

👇 Click on the image for a new way to code review

- Make big changes easier — review code in small groups of related files - Know where to start — see the whole change at a glance - Take a code tour — explore the change with an interactive tour - Make comments and review — all fully sync’ed with github [Try it now!](https://app.codesee.io/r/reviews?pr=2364&src=https%3A%2F%2Fgithub.com%2FfreeCodeCamp%2Fchapter)

Legend

CodeSee Map Legend