feat: increase the min height for content in laptops layout

freeCodeCamp / chapter

A self-hosted event management tool for nonprofits

BSD 3-Clause "New" or "Revised" License

1.92k stars 360 forks source link

feat: increase the min height for content in laptops layout #2438

Closed Sboonny closed 1 year ago

Sboonny commented 1 year ago

[x] I have read Chapter's contributing guidelines.
[x] My pull request has a descriptive title (not a vague title like Update README.md).
[x] My pull request targets the main branch of Chapter.

Screens with width between 1000px and 1440px have the footer away from the bottom of the layout.

ghost commented 1 year ago

👇 Click on the image for a new way to code review

#### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/freeCodeCamp/chapter/2438/4e15ea65/58c6a16a8145b13fd836a6c09208a265b187b5bd.svg)](https://app.codesee.io/r/reviews?pr=2438&src=https%3A%2F%2Fgithub.com%2FfreeCodeCamp%2Fchapter) #### Legend CodeSee Map legend

Sboonny commented 1 year ago

the more that I interact with it, the more that I hate min-height solution, the reason I have it, because body has #__next as a child, so I can't use body as a way to set the layout.

If you want, I can change pagelayout to have two extra elements that can create grid layout.

Sboonny commented 1 year ago

After turning it to grid, it looked more consistent, but it didn't reach what I desire.

Lets push the current change, and if someone wants a different way, I have already did it so adding it would be easier