fix: Add space between event image and header using PageLayout

freeCodeCamp / chapter

A self-hosted event management tool for nonprofits

BSD 3-Clause "New" or "Revised" License

1.92k stars 357 forks source link

fix: Add space between event image and header using PageLayout #2500

Closed randychilau closed 1 year ago

randychilau commented 1 year ago

[x] I have read Chapter's contributing guidelines.
[x] My pull request has a descriptive title (not a vague title like Update README.md).
[x] My pull request targets the main branch of Chapter.

Closes #2497

Gitpod workspace snapshot

as suggested in the bug description:

Also maybe separating margin might be set on the PageLayout, instead of individual pages.

Added to <Box> component, in PageLayout file, a margin top of 1rem spacing which in chakra is "4":

client/src/components/PageLayout/index.tsx

ghost commented 1 year ago

👇 Click on the image for a new way to code review

#### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/freeCodeCamp/chapter/2500/544b215f/3e0c856c3d380b9ea4f1a6c39a03eab2d1518133.svg)](https://app.codesee.io/r/reviews?pr=2500&src=https%3A%2F%2Fgithub.com%2FfreeCodeCamp%2Fchapter) #### Legend CodeSee Map legend

Sboonny commented 1 year ago

@all-contributors please add @randychilau for code.

gikf commented 1 year ago

@all-contributors would you be so kind and add @randychilau for code?

allcontributors[bot] commented 1 year ago

@gikf

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token ] in JSON at position 20426

Sboonny commented 1 year ago

@all-contributors would you be so kind and add @randychilau for code?

allcontributors[bot] commented 1 year ago

@Sboonny

I've put up a pull request to add @randychilau! :tada: