freeCodeCamp / chapter

A self-hosted event management tool for nonprofits
BSD 3-Clause "New" or "Revised" License
1.92k stars 357 forks source link

Fixing Subscribe Issue When RSVP #2513

Closed ElizabethBarco closed 1 year ago

ElizabethBarco commented 1 year ago

This is in response of: https://github.com/freeCodeCamp/chapter/issues/1993

Closes #1993

Add a line that makes the user subscribe when RSVP.

ghost commented 1 year ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/freeCodeCamp/chapter/2513/c2b90a4f/9e09cc352d76b9c5c64b646880f91e7db4612920.svg)](https://app.codesee.io/r/reviews?pr=2513&src=https%3A%2F%2Fgithub.com%2FfreeCodeCamp%2Fchapter) #### Legend CodeSee Map legend
Sboonny commented 1 year ago

Yeab, the issue doesn't exist anymore, but we can make the event join similar to what you did with chapter join.

Adding a checkbox in the model, but this is too much work currently.

image

gikf commented 1 year ago

You mean checkbox with something like Send me notifications about event updates?

Sboonny commented 1 year ago

Yeah, but it will be too complex because joining events is always shown, not like joining chapter

gikf commented 1 year ago

Hey @ElizabethBarco

Thank you for opening this pull request.

As the linked issue is no longer relevant I'm going to close this PR. Sorry for the confusion!

Thank you and happy coding.