freeCodeCamp / chapter

A self-hosted event management tool for nonprofits
BSD 3-Clause "New" or "Revised" License
1.92k stars 357 forks source link

feat: added venue data to confirmation emails #2519

Closed ttran913 closed 1 year ago

ttran913 commented 1 year ago

Closes #2229

Venue data will now be visible in attendee's confirmation emails. Added venue data(physicalLocation, streamingData, start_at, ends_at) to email-templates.ts. Modified confirmation related functions in event-email.ts to use the mentioned variables. Modified eventConfirmAttendeeEmail in resolver.ts to grab venue data. Modfied eventConfirmAttendeeEmail function to properly take in newly created parameters(streaming_url, venue_physical, venue_type, start_at, ends_at) in event-email.tests.ts. The test fails without these parameters.

ghost commented 1 year ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/freeCodeCamp/chapter/2519/1077605c/6601a7a77964fb46cbf84ad2c77c5e443724de31.svg)](https://app.codesee.io/r/reviews?pr=2519&src=https%3A%2F%2Fgithub.com%2FfreeCodeCamp%2Fchapter) #### Legend CodeSee Map legend
ttran913 commented 1 year ago

We have also removed all of our comments that that we have made.

ttran913 commented 1 year ago

I took your suggestions and hopefully made it more stylistically consistent with the rest of the file. Also removed all the unnecessary "venue as a whole data type" thing. Your "venue: { name: string | undefined } | null;" made resolver.ts stop complaining.

Sboonny commented 1 year ago

:sparkles: :tada: AWESOME! :tada: :sparkles:

Hi @ttran913, thanks for this pull request and for contributing to the code-base for the first time. We are looking forward to more contributions from you in the future.

Cheers & happy contributing!

Sboonny commented 1 year ago

@all-contributors would you be so kind and add @ttran913 for code?

allcontributors[bot] commented 1 year ago

@Sboonny

I've put up a pull request to add @ttran913! :tada: