Closed ttran913 closed 1 year ago
We have also removed all of our comments that that we have made.
I took your suggestions and hopefully made it more stylistically consistent with the rest of the file. Also removed all the unnecessary "venue as a whole data type" thing. Your "venue: { name: string | undefined } | null;" made resolver.ts stop complaining.
Hi @ttran913, thanks for this pull request and for contributing to the code-base for the first time. We are looking forward to more contributions from you in the future.
Cheers & happy contributing!
@all-contributors would you be so kind and add @ttran913 for code?
@Sboonny
I've put up a pull request to add @ttran913! :tada:
Update README.md
).main
branch of Chapter.Closes #2229
Venue data will now be visible in attendee's confirmation emails. Added venue data(physicalLocation, streamingData, start_at, ends_at) to email-templates.ts. Modified confirmation related functions in event-email.ts to use the mentioned variables. Modified eventConfirmAttendeeEmail in resolver.ts to grab venue data. Modfied eventConfirmAttendeeEmail function to properly take in newly created parameters(streaming_url, venue_physical, venue_type, start_at, ends_at) in event-email.tests.ts. The test fails without these parameters.