Closed lloydchang closed 1 year ago
Relates to https://github.com/freeCodeCamp/classroom/issues/415
Please enable
- "Require status checks to pass before merging"
- "Require branches to be up to date before merging"
via GitHub Protected Branches
GitHub Protected Branches is in a similar space as Merge Queue but is a different feature.
Enable GitHub's Merge Queue for freeCodeCamp classroom GitHub repository
Originated from https://codedayorg.slack.com/archives/C05ENB1VAKT/p1690507400216779?thread_ts=1690477315.733269
@theGaryLarson wrote to @ngillux
@lloydchang wrote to @GuillermoFloresV
👋 @GuillermoFloresV
While on mobile, can you enable GitHub's Merge Queue?
If not, it can wait until you can access a laptop.
Only maintainers like you and @utsab can enable GitHub's Merge Queue.
GitHub's Merge Queue is designed to address the acute condition summarized by @theGaryLarson, "
things started to break there because of asynchronous changes in pending PRs.
"Relates to https://github.com/freeCodeCamp/classroom/issues/328 https://github.com/freeCodeCamp/classroom/pull/400 https://github.com/freeCodeCamp/classroom/pull/401 https://github.com/freeCodeCamp/classroom/issues/402 https://github.com/freeCodeCamp/classroom/pull/366#issuecomment-1652616915
Relates to https://github.com/freeCodeCamp/classroom/pull/401#issuecomment-1656149999
@ngillux Did the response structure change in a different pull request https://github.com/freeCodeCamp/classroom/pull/366 from @theGaryLarson's https://github.com/freeCodeCamp/classroom/pull/353?
If yes, I believe the fundamental issue is what @theGaryLarson summarized yesterday, "
things started to break there because of asynchronous changes in pending PRs.
"Meanwhile, I submitted an issue request https://github.com/freeCodeCamp/classroom/issues/403 for @GuillermoFloresV to Enable GitHub's Merge Queue for freeCodeCamp classroom GitHub repository to address the fundamental issue of asynchronous changes in pending PRs.
Thank you!