search

freeCodeCamp / classroom

BSD 3-Clause "New" or "Revised" License
143 stars 120 forks source link

Create Snapshot test for UI components(`Error`,`Layout`,`classInviteTable`) #452

Closed Code-Victor closed 1 year ago

Code-Victor commented 1 year ago

Checklist:

Closes #309

Co-authored-by: Ayomide Onifade onifadeayomide328@gmail.com Co-authored-by: Christopher Alade aladechristoph@gmail.com Co-authored-by: Quawiyyah Abdulhameed abdulhameedqo@gmail.com

lloydchang commented 1 year ago

@Code-Victor @Quawiyyah @Ayomide6441 @Chrisdbeloved1

My understanding is that as next steps, you need to fix the following two failures:

  1. Classroom ci / Build and test (16.14.2) (pull_request) Failing after 49s Required Details
  2. CodeFactor Failing after 5s — 1 issue found. Details

The failures are in-lined at https://github.com/freeCodeCamp/classroom/pull/452/files 'studentData' is defined but never used

Details Screen Shot 2023-08-15 at 11 06 45 AM After you git push a new Git commit, GitHub will update https://github.com/freeCodeCamp/classroom/pull/452 and its section titled "Some checks were not successful: 2 failing and 1 successful checks." Please see screenshot below with context: Screen Shot 2023-08-15 at 10 02 26 AM
Code-Victor commented 1 year ago

Thanks @lloydchang, we've been able to fix it.