fix: add custom pagination

freeCodeCamp / contribute

> docs site for all things contributions. begin your contribution journey here.

https://contribute.freecodecamp.org

BSD 3-Clause "New" or "Revised" License

39 stars 54 forks source link

fix: add custom pagination #311

Closed a2937 closed 3 weeks ago

a2937 commented 1 month ago

Checklist:

[X] I have read freeCodeCamp's contribution guidelines.
[X] My pull request has a descriptive title (not a vague title like Update index.md)

Closes #304

I created a new component to take care of the issue with the previous and next issues. I basically reassign the next and previous values to what it is supposed to be present. There is a slight concern that the next link leads to the "Github" link on the side bar, but I'm not sure of the correct way to fix it. Additionally I like having code that is designed to keep indexes in bounds.

a2937 commented 1 month ago

I think I forgot to do something.

gikf commented 1 month ago

There is a slight concern that the next link leads to the "Github" link on the side bar, but I'm not sure of the correct way to fix it.

Would it be possible to use updatePagination to disable the next link? If yes, then come to mind two options:

Checking if next link would correspond to page from docs collection.
Adding optional external property to the link item, which would be used to ignore external links from the next/prev.