fix: update basic-css code to align with instructions - Githubissues

freeCodeCamp / curriculum

The freeCodeCamp curriculum and lesson editor

Creative Commons Attribution Share Alike 4.0 International

81 stars 125 forks source link

fix: update basic-css code to align with instructions #185

Closed SubhrajyotiSen closed 6 years ago

SubhrajyotiSen commented 6 years ago

Description

The instruction speaks of a typo that is non-existent in the code. So introduce the typo that is referred to in the instructions. Additionally update tests to reflect the typo.

Pre-Submission Checklist

[x] Your pull request targets the dev branch.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/challenge-tests)
[ ] All new and existing tests pass the command npm test.
[ ] Use npm run commit to generate a conventional commit message. Learn more here: https://conventionalcommits.org/#why-use-conventional-commits
[ ] The changes were done locally on your machine and NOT GitHub web interface. If they were done on the web interface you have ensured that you are creating conventional commit messages.

Checklist:

[ ] Tested changes locally.
[ ] Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #XXXXX

SubhrajyotiSen commented 6 years ago

Reference: https://github.com/freeCodeCamp/freeCodeCamp/issues/17935 Mentioning it separately since the issue in on a different repo