fix(challenges): fix third test for template literals - Githubissues

freeCodeCamp / curriculum

The freeCodeCamp curriculum and lesson editor

Creative Commons Attribution Share Alike 4.0 International

81 stars 125 forks source link

fix(challenges): fix third test for template literals #192

Closed johnkennedy9147 closed 6 years ago

johnkennedy9147 commented 6 years ago

Description

replaced the overly long and complex regex which tests for use of template literals with a much simpler one that has the same effect

also fixed \n not being displayed as it was not escaped or surrounded by code tags

ISSUES CLOSED: #135

Pre-Submission Checklist

[x] Your pull request targets the dev branch.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/challenge-tests)
[x] All new and existing tests pass the command npm test.
[x] Use npm run commit to generate a conventional commit message. Learn more here: https://conventionalcommits.org/#why-use-conventional-commits
[x] The changes were done locally on your machine and NOT GitHub web interface. If they were done on the web interface you have ensured that you are creating conventional commit messages.

Checklist:

[x] Tested changes locally.
[x] Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #135

scissorsneedfoodtoo commented 6 years ago

@johnkennedy9147, thank you for continuing to improve this problem! I just found a couple of small things I'll leave as a review.

scissorsneedfoodtoo commented 6 years ago

@johnkennedy9147, thank you for all of your hard work here. Everything LGTM!