fix(challenges): corrected challenge instructions

Nirajn2311 commented 6 years ago

ISSUES CLOSED: #24

Description

Changed the instructions for https://learn.freecodecamp.org/responsive-web-design/applied-visual-design/use-the-u-tag-to-underline-text

Before:

Wrap the u tag around the text "Ph.D. students". It should not include the parent div that has the class of cardText.

After:

Wrap the u tag only around the text “Ph.D. students”.

Pre-Submission Checklist

[x] Your pull request targets the dev branch.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/challenge-tests)
[x] All new and existing tests pass the command npm test.
[x] Use npm run commit to generate a conventional commit message. Learn more here: https://conventionalcommits.org/#why-use-conventional-commits
[x] The changes were done locally on your machine and NOT GitHub web interface. If they were done on the web interface you have ensured that you are creating conventional commit messages.

Checklist:

[x] Tested changes locally.
[x] Addressed currently open issue (replace XXXXX with an issue no in next line)

joshalling commented 6 years ago

@Nirajn2311, we probably want to remove the test that checks that the u tag doesn't have any div children as it no longer applies.

Nirajn2311 commented 6 years ago

@joshalling so I should just remove the following test

{
          "text":
            "The <code>u</code> tag should not wrap around the parent <code>div</code> tag.",
          "testString":
            "assert($('u').children('div').length === 0, 'The <code>u</code> tag should not wrap around the parent <code>div</code> tag.');"
}

joshalling commented 6 years ago

@Nirajn2311 Yeah. I think it starts on line 325.

scissorsneedfoodtoo commented 6 years ago

@Nirajn2311, everything LGTM! Just waiting for that unnecessary test to be removed. And thanks for your support here, @joshalling.

Nirajn2311 commented 6 years ago

@scissorsneedfoodtoo @joshalling I have updated the requested changes. This PR is ready to be merged once it is has been checked.

scissorsneedfoodtoo commented 6 years ago

Everything LGTM :+1: Thank you for this fix @Nirajn2311, and @joshalling again for your help here.

freeCodeCamp / curriculum