Closed Nirajn2311 closed 6 years ago
@Nirajn2311, we probably want to remove the test that checks that the u tag doesn't have any div children as it no longer applies.
@joshalling so I should just remove the following test
{
"text":
"The <code>u</code> tag should not wrap around the parent <code>div</code> tag.",
"testString":
"assert($('u').children('div').length === 0, 'The <code>u</code> tag should not wrap around the parent <code>div</code> tag.');"
}
@Nirajn2311 Yeah. I think it starts on line 325.
@Nirajn2311, everything LGTM! Just waiting for that unnecessary test to be removed. And thanks for your support here, @joshalling.
@scissorsneedfoodtoo @joshalling I have updated the requested changes. This PR is ready to be merged once it is has been checked.
Everything LGTM :+1: Thank you for this fix @Nirajn2311, and @joshalling again for your help here.
ISSUES CLOSED: #24
Description
Changed the instructions for https://learn.freecodecamp.org/responsive-web-design/applied-visual-design/use-the-u-tag-to-underline-text
Before:
After:
Pre-Submission Checklist
dev
branch.fix/
,feature/
, ortranslate/
(e.g.fix/challenge-tests
)npm test
.npm run commit
to generate a conventional commit message. Learn more here: https://conventionalcommits.org/#why-use-conventional-commitsChecklist: