freeCodeCamp / curriculum

The freeCodeCamp curriculum and lesson editor
Creative Commons Attribution Share Alike 4.0 International
81 stars 125 forks source link

Duplicated CSS top property in the last challenge in Applied Visual Design #205

Closed jromest closed 6 years ago

jromest commented 6 years ago

Description

I just found a duplicated CSS top property in Applied Visual Design: Make Motion More Natural Using a Bezier Curve, is this intended?

.balls {
    border-radius: 50%;
    top: 249px;
    position: fixed;  
    width: 50px;
    height: 50px;
    top: 60%;
    animation-name: jump;
    animation-duration: 2s;
    animation-iteration-count: infinite;
}

Link

https://learn.freecodecamp.org/responsive-web-design/applied-visual-design/make-motion-more-natural-using-a-bezier-curve

Nirajn2311 commented 6 years ago

I think that top: 249px; should be removed as there was no change in animation with or without it but when I removed top: 60% there was a change in the position of the balls. Any beginner or first-timer is free to do a PR.

The code to be edited for this challenge can be found here

https://github.com/freeCodeCamp/curriculum/blob/dev/challenges/01-responsive-web-design/applied-visual-design.json#L3664

TomerPacific commented 6 years ago

Hi @Nirajn2311 , mind if I take this one on?

Nirajn2311 commented 6 years ago

@TomerPacific you may go ahead with the fix.