fix(challenges): spelling and grammar errors addressed - Githubissues

freeCodeCamp / curriculum

The freeCodeCamp curriculum and lesson editor

Creative Commons Attribution Share Alike 4.0 International

81 stars 125 forks source link

fix(challenges): spelling and grammar errors addressed #227

Closed RyanPisuena closed 6 years ago

RyanPisuena commented 6 years ago

Description

Basic grammar and spellng changes. Comunicate -> communicate

Pre-Submission Checklist

[x] Your pull request targets the dev branch.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/challenge-tests)
[x] All new and existing tests pass the command npm test.
[x] Use npm run commit to generate a conventional commit message. Learn more here: https://conventionalcommits.org/#why-use-conventional-commits
[x] The changes were done locally on your machine and NOT GitHub web interface. If they were done on the web interface you have ensured that you are creating conventional commit messages.

Checklist:

[x] Tested changes locally.
[x] Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #XXXXX

joshalling commented 6 years ago

@RyanPisuena It looks like the Travis CI build is failing because your commit message is not in line with the conventional commit format. It should pass if you fix your commit message. You can follow these steps to change your message

RyanPisuena commented 6 years ago

@joshalling Thanks for the heads up!

joshalling commented 6 years ago

@RyanPisuena I think you misunderstood. You will need to run git commit --amend on your branch to change the actual commit message. If you want me to walk you through it send me a message on gitter.

RyanPisuena commented 6 years ago

@joshalling Hi there! Ran git command through command prompt :)

joshalling commented 6 years ago

Awesome! Now you just need to wait for an issue moderator to check and merge this and you will have your first PR accepted.

scissorsneedfoodtoo commented 6 years ago

:sparkles: :sparkles: :sparkles: Awesome! Congratulations on your first contribution to freeCodeCamp! :sparkles: :sparkles: :sparkles:

Thank you for submitting a PR for this issue, @RyanPisuena. We're all really looking forward to your next contribution. Also, thank you @joshalling for your help QA'ing this.