Open joshalling opened 6 years ago
Actually it's worse than that as this passes
junk grid-column-gap: 20px;
and
junkgrid-column-gap: 20px;
We could check there is nothing else between the two forward slashes (in the comments) other than whitespace?
So, this would pass:
/* add your code below this line */
grid-column-gap: 20px;
/* add your code above this line */
but this would not:
/* add your code below this line */
junk grid-column-gap: 20px;
/* add your code above this line */
The grid column gap challenge doesn't ensure that your declaration is within the
.container
rule. This means you can put thegrid-column-gap
declaration in a different rule and still pass the challenge.To Reproduce
Steps to reproduce the behavior:
.container
ruleThis issue persists throughout a lot of the Grid challenges. I propose that we update the regex to prevent the test from passing if a closing curly brace is present between the
.container
selector and thegrid-column-gap
declaration.