freeCodeCamp / curriculum

The freeCodeCamp curriculum and lesson editor
Creative Commons Attribution Share Alike 4.0 International
81 stars 125 forks source link

fix(challenges): fix grid-gap shorthand regex #232

Closed joshalling closed 6 years ago

joshalling commented 6 years ago

ISSUES CLOSED: #229

Description

This updates the regex to use a + instead of a * between the two measurements so that it requires at least one space.

Pre-Submission Checklist

Checklist:

Closes #229

moT01 commented 6 years ago

Thanks for contributing! 👍

joshalling commented 6 years ago

@moT01 It looks like there was a conflict with this pull request and #233 because of the prettier formatting, and the merge removed my fix.

moT01 commented 6 years ago

sorry about that, that's my fault - I swear I double checked it when I was resolving that conflict, but I must have deleted the wrong line. Not sure the best way to fix it - probably easiest to just make another PR - Do you want to do that and hopefully I won't mess it up this time? If not, I can.

joshalling commented 6 years ago

I can submit another PR later today. Thanks!

joshalling commented 6 years ago

@moT01 I just submitted another PR. (#237)

raisedadead commented 6 years ago

:tada: This PR is included in version 3.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: