fix(challenges): fix grid-gap shorthand regex - Githubissues

freeCodeCamp / curriculum

The freeCodeCamp curriculum and lesson editor

Creative Commons Attribution Share Alike 4.0 International

81 stars 125 forks source link

fix(challenges): fix grid-gap shorthand regex #237

Closed joshalling closed 6 years ago

joshalling commented 6 years ago

ISSUES CLOSED: #229

Description

This updates the regex to use a + instead of a * between the two measurements so that it requires at least one space.

Pre-Submission Checklist

[x] Your pull request targets the dev branch.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/challenge-tests)
[x] All new and existing tests pass the command npm test.
[x] Use npm run commit to generate a conventional commit message. Learn more here: https://conventionalcommits.org/#why-use-conventional-commits
[x] The changes were done locally on your machine and NOT GitHub web interface. If they were done on the web interface you have ensured that you are creating conventional commit messages.

Checklist:

[x] Tested changes locally.
[x] Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #229

moT01 commented 6 years ago

thanks again @joshalling

raisedadead commented 6 years ago

:tada: This PR is included in version 3.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: