Closed Nirajn2311 closed 6 years ago
@Nirajn2311, thank you as always for taking the time to make these changes. Unfortunately, there's no issue, and the prettier formatting makes it a bit difficult to see what changes you actually made to the tests. Could you list the names of the challenges you've updated? Hopefully then we'll be able to QA and merge this quickly.
@scissorsneedfoodtoo the challenges are:
Match All Letters and Numbers
Match Whitespace
Match Non-Whitespace Characters
Also could you check if I resolved merge conflict correctly.
@Nirajn2311, sorry again for the delay. Thank you for letting me know which challenges you updated. Everything LGTM :+1: :+1:
Description
The regex challenges for checking whitespace, non-whitespace and alphanumeric characters were not checking if the user was using the respective shorthand characters and so the user could pass the challenge without using them.
Pre-Submission Checklist
dev
branch.fix/
,feature/
, ortranslate/
(e.g.fix/challenge-tests
)npm test
.npm run commit
to generate a conventional commit message. Learn more here: https://conventionalcommits.org/#why-use-conventional-commitsChecklist:
Closes #XXXXX