freeCodeCamp / curriculum

The freeCodeCamp curriculum and lesson editor
Creative Commons Attribution Share Alike 4.0 International
81 stars 125 forks source link

fix(challenges): check for shorthand character in regex #238

Closed Nirajn2311 closed 6 years ago

Nirajn2311 commented 6 years ago

Description

The regex challenges for checking whitespace, non-whitespace and alphanumeric characters were not checking if the user was using the respective shorthand characters and so the user could pass the challenge without using them.

Pre-Submission Checklist

Checklist:

Closes #XXXXX

scissorsneedfoodtoo commented 6 years ago

@Nirajn2311, thank you as always for taking the time to make these changes. Unfortunately, there's no issue, and the prettier formatting makes it a bit difficult to see what changes you actually made to the tests. Could you list the names of the challenges you've updated? Hopefully then we'll be able to QA and merge this quickly.

Nirajn2311 commented 6 years ago

@scissorsneedfoodtoo the challenges are:

Also could you check if I resolved merge conflict correctly.

scissorsneedfoodtoo commented 6 years ago

@Nirajn2311, sorry again for the delay. Thank you for letting me know which challenges you updated. Everything LGTM :+1: :+1: