Typo in Basic Data Structures: Combine Arrays with the Spread Operator #18003 FIX

freeCodeCamp / curriculum

The freeCodeCamp curriculum and lesson editor

Creative Commons Attribution Share Alike 4.0 International

81 stars 125 forks source link

Typo in Basic Data Structures: Combine Arrays with the Spread Operator #18003 FIX #239

Closed TomerPacific closed 6 years ago

TomerPacific commented 6 years ago

Description

Fixing typo in algorithms and data structures lesson having to do with combining arrays with the spread operator. Deleted the multiple word 'more'.

Pre-Submission Checklist

[X] Your pull request targets the dev branch.
[X] Branch starts with either fix/, feature/, or translate/ (e.g. fix/challenge-tests)
[X] All new and existing tests pass the command npm test.
[X] Use npm run commit to generate a conventional commit message. Learn more here: https://conventionalcommits.org/#why-use-conventional-commits
[X] The changes were done locally on your machine and NOT GitHub web interface. If they were done on the web interface you have ensured that you are creating conventional commit messages.

Checklist:

[X] Tested changes locally.
[X] Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes https://github.com/freeCodeCamp/freeCodeCamp/issues/18003

Nirajn2311 commented 6 years ago

@TomerPacific in your PR description, when you put a ‘x’ in [] there should be no spaces otherwise it won’t be recognised as a checkbox.

Also before you commit your changes, execute the command npm run commit as FCC follows a certain commit message structure and Travis CI follows it otherwise the build will fail.

TomerPacific commented 6 years ago

@Nirajn2311 , thank you for your feedback.

Do I just close the pull request now?

Nirajn2311 commented 6 years ago

@TomerPacific you have to wait until one of FCC top contributors checks this PR and merges it. Then the PR will automatically close and you will have to close the issue back in FCC repo. As I am not one yet so I can’t merge your PR but I can review it.

scissorsneedfoodtoo commented 6 years ago

@TomerPacific, unfortunately it seems like the Travis CI build is failing. It's an easy fix, though, since it's just a problem with your commit message.

Please take a look at the Commit Your Changes section of the Contributor's Guide. There are some instructions about conventional commit messages and how to edit your message there.

Basically you want to change the current message from Fixing typo in algorithms and data structures lesson having to do with combining arrays with the spread operator. Deleted the multiple more word to something like fix(challenges): fixed typo in algorithms and ds by running git commit --amend on your feature/fixing-typo-spread-operator branch. Then you should be good to go after a force push back to your remote branch.

TomerPacific commented 6 years ago

Hey @scissorsneedfoodtoo , I have done as you have requested. Hopefully, the Travis CI build will pass and everything will be good to go.

Nirajn2311 commented 6 years ago

@TomerPacific congrats on your first PR.

scissorsneedfoodtoo commented 6 years ago

:sparkles: :sparkles: :sparkles: Awesome! Congratulations on your first contribution to freeCodeCamp! :sparkles: :sparkles: :sparkles:

Thank you for submitting a PR for this issue, @TomerPacific. We're all really looking forward to your next contribution!