freeCodeCamp / curriculum

The freeCodeCamp curriculum and lesson editor
Creative Commons Attribution Share Alike 4.0 International
81 stars 125 forks source link

Typo in Basic Data Structures: Combine Arrays with the Spread Operator #248

Closed Nirajn2311 closed 6 years ago

Nirajn2311 commented 6 years ago

@halcyondays22 commented on Sat Aug 11 2018

Describe your problem and - if possible - how to reproduce it

In second paragraph, there are two "more"s before the word complex.

Add a Link to the page with the problem

https://learn.freecodecamp.org/javascript-algorithms-and-data-structures/basic-data-structures/combine-arrays-with-the-spread-operator

Tell us about your browser and operating system

If possible, add a screenshot here

screen shot 2018-08-10 at 10 00 46 pm


@TomerPacific commented on Sat Aug 11 2018

I'd like to be able to fix this issue as a first time contributor to this repository, if no one has any reservations.


@Nirajn2311 commented on Sat Aug 11 2018

@TomerPacific You may start working on the fix. The challenges files can be found in the curriculum repo.


@TomerPacific commented on Sat Aug 11 2018

@Nirajn2311 , I have found where to fix the mistake and have made the correct fix, but when I check the status of my branch, there are no differences. Meaning, nothing has been changed.

I have gone to freeCodeCamp\node_modules\@freecodecamp\curriculum\dist\challenges\02-javascript-algorithms-and-data-structures

and made the fix there. Is that the right place?

Can you help me out in figuring out what I am missing?

Just to clarify, I have managed to run the FCC environment.


@Nirajn2311 commented on Sat Aug 11 2018

@TomerPacific the challenges files are stored at https://github.com/freeCodeCamp/curriculum. The file you are looking for to edit is https://github.com/freeCodeCamp/curriculum/blob/dev/challenges/02-javascript-algorithms-and-data-structures/basic-data-structures.json#L396

FCC gets the curriculum package so it is found in node modules(this happens when you run npm install).


@TomerPacific commented on Sat Aug 11 2018

Hey @Nirajn2311 ,

thanks for the quick reply.

I just want to make sure that what I am about to do is correct.

Since I only forked the freeCodeCamp/freeCodeCamp repository, I need to fork the freeCodeCamp/curriculum repository, create a new branch there, fix the typo and open a pull request in that repository?


@Nirajn2311 commented on Sat Aug 11 2018

@TomerPacific Bullseye my friend.


@amar633 commented on Sun Aug 12 2018

how to get rid of these unnecessary emails? mute not working. thanks

Get Outlook for iOShttps://aka.ms/o0ukef


From: Niraj Nandish notifications@github.com Sent: Saturday, August 11, 2018 2:50 PM To: freeCodeCamp/freeCodeCamp Cc: Subscribed Subject: Re: [freeCodeCamp/freeCodeCamp] Typo in Basic Data Structures: Combine Arrays with the Spread Operator (#18003)

@TomerPacifichttps://github.com/TomerPacific Bullseye my friend.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/freeCodeCamp/freeCodeCamp/issues/18003#issuecomment-412294407, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AfJhmqs2FOg738xREYkaCTXyPikcmwMfks5uPydxgaJpZM4V5Aec.


@amar633 commented on Sun Aug 12 2018

I Want to unduscriiiiiiiiibbbbbbeee!!!!


@TomerPacific commented on Sun Aug 12 2018

Hi @Nirajn2311 , I have created a pull request. PR

Thank you for all your help.