feat(interview-prep): Porting Rosetta Problems - Githubissues

freeCodeCamp / curriculum

The freeCodeCamp curriculum and lesson editor

Creative Commons Attribution Share Alike 4.0 International

81 stars 125 forks source link

feat(interview-prep): Porting Rosetta Problems #252

Closed NitronR closed 6 years ago

NitronR commented 6 years ago

Description

Pre-Submission Checklist

[ ] Your pull request targets the dev branch.
[ ] Branch starts with either fix/, feature/, or translate/ (e.g. fix/challenge-tests)
[x] All new and existing tests pass the command npm test.
[x] Use npm run commit to generate a conventional commit message. Learn more here: https://conventionalcommits.org/#why-use-conventional-commits
[x] The changes were done locally on your machine and NOT GitHub web interface. If they were done on the web interface you have ensured that you are creating conventional commit messages.

Checklist:

[x] Tested changes locally.
[ ] Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #XXXXX

scissorsneedfoodtoo commented 6 years ago

@NitronR, sorry for the delay in reviewing this. All of the descriptions look good! Just noticed a few things with the formatting. Left some notes as comments

NitronR commented 6 years ago

Sure!! I will take a look.

scissorsneedfoodtoo commented 6 years ago

Merging now since the whole text displaying thing is a minor issue for now.

As always, thank you for all your hard work!