search

freeCodeCamp / curriculum

The freeCodeCamp curriculum and lesson editor
Creative Commons Attribution Share Alike 4.0 International
81 stars 124 forks source link

flex-direction row challenge regex bug #260

Closed joshalling closed 6 years ago

joshalling commented 6 years ago

Describe the bug

The flex-direction row challenge will not pass if you have other declarations above flex-direction.

To Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Copy the following code into the header rule. 
    margin: 10px;
padding: 1px;
display: flex;
flex-direction: row;
  3. Click Run the Tests and see that the first rule doesn't pass when it should.
  4. Now if you remove the margin and padding rules then it passes.

Additional context

This is happening because the current regex only allows 3 lines of code between the selector and the flex-direction declaration.

raisedadead commented 5 years ago

:tada: This issue has been resolved in version 3.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: